chore (db): seeding script + seeding command in package.json#120
Open
chore (db): seeding script + seeding command in package.json#120
Conversation
liangricky7
requested changes
Feb 4, 2026
Contributor
There was a problem hiding this comment.
Great start, just a few changes and additions to make.
- Make sure to cleanup DB connections to avoid pooling; write const client = postgres(connectionString) and then db = drizzle(client) so we can then run client.end() to close connection
- add some more comments that explain each step/block of code to make things much more readable for me/future readers, since right now it may take a bit to go over
Contributor
There was a problem hiding this comment.
Also! Go over the auto checks (the linter and the database thing) and make sure you properly rewrite your code accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.