Support for single line stripe parsing in LVM #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for singleline stripe parsing in LVM - Add tests for MetadataSegmentSection class
Owner
|
Great work! Thanks again for your valuable contributions! |
Author
|
Hi, thanks for a quick review and merge. How far are we from the 1.0.53 release? |
Owner
I should be able to do that within a couple days! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of MetadataSegmentSection.Parse method cannot parse single line stripe arrays (for example: stripes = ["pv0", 512]) and throws an exception.
This change adds support for single line stripe array parsing and includes unit tests for the MetadataSegmentSection class to verify proper handling of both single-line and multi-line stripe formats.