Ensure correct timezone is set on filetimes #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
This looks very good! Thanks a lot for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the DateTime was unknown kind by default which meant if you called file.LastWriteTimeUtc.ToUniversalTime() it would give you a different time compared to file.LastWriteTImeUtc. This isn't 'wrong' in theory as we say it is unknown and it is UTC time but as dotnet generally assumes localtime on unknown datetimes it might confuse the user.
The only one technically wrong was XFS which was implicitly getting the localtime. I would also argue anywhere it got converted to a DateTimeOffset was also 'wrong' because when you convert an unspecified timezone DateTime to a DateTimeOffset it treats it as local and sets DateTimeOffset.Offset to the local offset.