Rename Value::VarChar to Xml
#4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any comments @enteryournamehere or @Jettford ? |
Xiphoseer
force-pushed
the
feature/rename-text8-xml
branch
from
540b40a to
f457ed9
Compare
Xiphoseer
force-pushed
the
feature/rename-text8-xml
branch
from
f457ed9 to
4a0a768
Compare
Xiphoseer
force-pushed
the
feature/rename-text8-xml
branch
from
4a0a768 to
3c86d7b
Compare
|
Changes look good, I suppose |
I guess better late then never but LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change, please make sure your dependencies are pinned.