Skip to content

on masternode output include alias name in order to identify easily which TXID belongs to which alias name + remove duplicate code #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
grapeLux2 wants to merge 3 commits into
base: master_candidate
Choose a base branch
from
Open

on masternode output include alias name in order to identify easily which TXID belongs to which alias name + remove duplicate code #99

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e4b02e4
Merge pull request #16 from LUX-Core/master_candidate
grapeLux2 Dec 29, 2019
2cd9be7
remove duplicate code
grapeLux2 Jan 17, 2020
5233ac6
[RPC] masternode output: include alias name in order to identify easi…
grapeLux2 Jan 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 17 additions & 18 deletions src/rpcdarksend.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,14 +475,26 @@ UniValue masternode(const UniValue& params, bool fHelp) {
}
}

if (strCommand == "outputs"){
if (strCommand == "outputs") {
// Find possible candidates
vector<COutput> possibleCoins = activeMasternode.SelectCoinsMasternode();

UniValue obj(UniValue::VOBJ);
for (const auto& out : possibleCoins) {
obj.push_back(Pair(out.tx->GetHash().ToString().c_str(), boost::lexical_cast<std::string>(out.i)));

for (COutput& out : possibleCoins) {

for (CMasternodeConfig::CMasternodeEntry mne : masternodeConfig.getEntries()) { // check if the TXID is currently in masternode.conf,

std::string MNC = mne.getTxHash(); // TXID from masternode in masternode.conf
std::string possibleMN = out.tx->GetHash().ToString(); // TXID for 16120 LUX tx
if (possibleMN==MNC){
obj.push_back(Pair(out.tx->GetHash().ToString().c_str(), boost::lexical_cast<std::string>(out.i) + " TXID is being used by a MN in your wallet," + " MN alias = " + mne.getAlias().c_str()) );
}else{
obj.push_back(Pair(out.tx->GetHash().ToString().c_str(), boost::lexical_cast<std::string>(out.i)));
}
}

}

return obj;
}

Expand Down Expand Up @@ -565,20 +577,7 @@ UniValue masternode(const UniValue& params, bool fHelp) {

return resultObj;
}

if (strCommand == "outputs") {
// Find possible candidates
vector<COutput> possibleCoins = activeMasternode.SelectCoinsMasternode();

UniValue obj(UniValue::VOBJ);
for (COutput& out : possibleCoins) {
obj.push_back(Pair(out.tx->GetHash().ToString().c_str(), boost::lexical_cast<std::string>(out.i)));
}

return obj;

}


return NullUniValue;
}