Conversation
DuoMap is an attemt to remove all mappings from the SpecValue type class by having a single 'base map'. DuoMap contains two values (probably mappings) one for enums and one for functions. See #9 on github for the motivation. This initial experiment rewrites DefMap as a proof of concept.
Unwrapping and rewrapping the newtype layer adds quite some noise to the code. To simplify this a 'trick' like the one from the newtype package is used to make it simpler and less verbose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of #9 by changing the definition of the specification related mappings to use the new datatype
This makes it possible to define the mappings in separate modules from the original values.