server build does not need separate flow engine jar#846
server build does not need separate flow engine jar#846labkey-matthewb merged 4 commits intodevelopfrom
Conversation
flow/build.gradle
Outdated
| project.tasks.named('assemble').configure { dependsOn(project.tasks.engineJar) } | ||
| project.tasks.named('module').configure { dependsOn(project.tasks.engineJar) } | ||
|
|
||
| // The server build does not need flow_engine.jar |
There was a problem hiding this comment.
I think it does actually need the engineJar, as currently assembled. When I tried to simply remove this before, I found that the module code references some classes that are in the engine. That could could possibly be moved to the API jar for this module, but I don't know enough about the workings here to say anything with confidence.
There was a problem hiding this comment.
Hmm, I ran the flow tests after deleting the jar and I think it worked fine... I'll check again.
There was a problem hiding this comment.
TeamCity is definitely not happy, though.
There was a problem hiding this comment.
thank you for the help!
labkey-matthewb
changed the title
labkey-susanh
left a comment
labkey-susanh
left a comment
There was a problem hiding this comment.
I think you probably want to remove this line from the engineJar task configuration:
jar.destinationDirectory.set(project.file(project.labkey.explodedModuleLibDir))
The default destination directory is build/modules/flow/libs, which seems a more natural place to find the jar if it's going to be used outside the module. If the engine jar is in the explodedModule/lib directory, it will be included when the module is built and we could still have a dependency version problem when the version changes (less likely since the jar won't always be present, but still annoying if it happens).
Co-authored-by: Susan Hert <susanh@labkey.com>
2 participants
Rationale
Do we need to do anything to the code that validates version numbers?
Related Pull Requests
Changes