Issue 52461: Luminex Levey-Jennings report 4PL curve fit comparison report not working for assay run selected from another folder#851
Merged
cnathe merged 1 commit intorelease24.11-SNAPSHOTfrom Mar 5, 2025
Conversation
…eport not working for assay run selected from another folder - add LABKEY.Query.containerFilter.allFolders to selectRows request in viewCurvesClicked()
labkey-klum
approved these changes
Mar 4, 2025
cnathe
added
TeamCity test review complete
and removed
needs TeamCity test review
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
https://www.labkey.org/home/Developer/issues/issues-details.view?issueId=52461
We are correctly using the allFolders container filter to get the data for the Levey-Jennings report and plot, but we were not using that containerFilter to looking RunId values for the selected rows when clicking "View 4PL Curves".
Changes