Conversation
| clickButton("Create Run Group"); | ||
| setFormElement(Locator.name("name"), RUN_GROUP3_NAME); |
There was a problem hiding this comment.
Should there be a wait after the clickButton and before the setFormElement?
Like:
waitForElement(Locator.name("name"));
There was a problem hiding this comment.
The page is probably static. Waiting for elements isn't quite as necessary outside of the apps.
There was a problem hiding this comment.
Yes, this is all server-rendered HTML. Waits are fine to add but probably not strictly necessary here.
| clickButton("Create Run Group"); | ||
| setFormElement(Locator.name("name"), RUN_GROUP3_NAME); |
There was a problem hiding this comment.
The page is probably static. Waiting for elements isn't quite as necessary outside of the apps.
Co-authored-by: Trey Chadick <tchad@labkey.com>
labkey-jeckels
left a comment
labkey-jeckels
left a comment
There was a problem hiding this comment.
One small suggestion for additional validation
| clickButton("Create Run Group"); | ||
| setFormElement(Locator.name("name"), RUN_GROUP3_NAME); |
There was a problem hiding this comment.
Yes, this is all server-rendered HTML. Waits are fine to add but probably not strictly necessary here.
| _customizeViewsHelper.applyCustomView(); | ||
| assertNotEquals("All rows should have a value for the run group", 0, dataTable.getDataRowCount()); | ||
| dataTable.setFilter("Fraction/Run/ExperimentRunLSID/RunGroups", "Is Blank"); | ||
| assertEquals("All rows should have a value for the run group", 0, dataTable.getDataRowCount()); |
There was a problem hiding this comment.
It would be nice to check the value is rendering correctly here, making sure we don't have a broken lookup or similar.
4 participants
Rationale
This adds test coverage for 52245 and sets up the same repro scenario as outlined in the issue.