Closed
Conversation
…nus the given interval
|
ERROR: A pull request from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Our SOP states that "in any 30-day period the animal blood collection should not exceed 20% of the animal's estimated blood volume." The current blood calculation that happens during validation when blood draws are requested/performed was adding an additional day in the interval, but, the animal should actually get replenished a day sooner.
Here's an example:
If an animal had blood drawn on 2/12/2025, the 30 day period would bring us through 3/13/2025, and the animal should get replenished on 3/14/2025. The current blood calculation subtracts 30 days (or whatever the interval may be) to the current date (which turns out to be a 31 day period). It should only be 30 days total much like the current blood draw table here https://github.com/LabKey/snprcEHRModules/blob/75291bccef3cdc7055d0461686c9836497d77ba9/snprc_ehr/resources/queries/study/currentBloodDraws.sql#L72.
Related Pull Requests
Changes