Issue 52277: SNDTest.testSuperPackageApis fails with DB deadlock#974
Merged
labkey-jeckels merged 2 commits intorelease24.11-SNAPSHOTfrom Jun 26, 2025
Merged
Conversation
|
ERROR: A pull request from |
labkey-danield
approved these changes
Jun 25, 2025
|
|
||
| checkExpectedErrors(1); | ||
| resetErrors(); | ||
| // checkExpectedErrors(1); |
Contributor
There was a problem hiding this comment.
Maybe remove this commented line? Or add a comment as to why it is commented out.
Contributor
Author
There was a problem hiding this comment.
Thanks for the reminder to revert that edit. I had to do that hack to run the test locally but didn't intend to push it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This test is failing intermittently but regularly. It's a SQLServer deadlock between loading the schema browser and doing the import. We can sidestep it by waiting for the query dependency analysis to complete before hitting the APIs.
Changes