Better handling of GeneticCalculationsImportTask cancels#975
Merged
bbimber merged 2 commits intorelease25.3-SNAPSHOTfrom Jun 26, 2025
Merged
Better handling of GeneticCalculationsImportTask cancels#975bbimber merged 2 commits intorelease25.3-SNAPSHOTfrom
bbimber merged 2 commits intorelease25.3-SNAPSHOTfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user hits cancel on a pipeline job, they should reasonably expect the job to cancel. While GeneticCalculationsImportTask already has a check for job.isCancelled(), I dont think isCancelled() actually returns the correct value unless job.updateStatusForTask() is called. This PR adds this, which makes the job check the current status of the job every time it completes a batch of imports, and will therefore cancel the job in a more timely manner.
While I was editing this, I also made an option to specify dayOfWeek, in addition to hourOfDay for the cron schedule. If blank the job will run nightly, as-is. The would allow admins to pick a day of the week to convert this into a weekly job.