Conversation
labkey-nicka
approved these changes
Mar 17, 2026
packages/components/src/internal/components/editable/actions.ts
Outdated
Show resolved
Hide resolved
packages/components/src/internal/components/editable/actions.ts
Outdated
Show resolved
Hide resolved
| while (start < value.length) { | ||
| let end; | ||
| const ch = value[start]; | ||
| // Tolerate a single space before a properly quoted value |
Contributor
There was a problem hiding this comment.
Should this handle space after the quotes as well?
expect(parseCsvString('1, "2,3" , 4', ',', true)).toStrictEqual(['1', '2,3', ' 4']);
Contributor
Author
There was a problem hiding this comment.
I don't feel strong about this one but I could be convinced otherwise. I also didn't handle when there are multiple white spaces. BTW, I tagged you for re-review since I pushed additional changes for 2 small designer UI issues. I don't plan to include more issues in this PR.
Contributor
There was a problem hiding this comment.
Alright, perhaps put a TODO comment here regarding support for multiple spaces and spaces after quoted values.
labkey-nicka
approved these changes
Mar 17, 2026
XingY
changed the title
XingY
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Some UX update for "Allow multiple selections" checkbox
Related Pull Requests
Changes