Skip to content

Issue 53197: Field name with double byte character can cause client side exception in Firefox when trying to customize grid view #6825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cnathe merged 7 commits into from
Jul 10, 2025
Merged

Issue 53197: Field name with double byte character can cause client side exception in Firefox when trying to customize grid view #6825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6f61884
Issue 53197: LK Customize View to encode column id for ExtJS issue in…
cnathe Jun 30, 2025
3666063
Merge branch 'develop' into fb_customizeView53197
cnathe Jul 7, 2025
88b01e2
use encodeURI instead to account for child lookup nodes in tree
cnathe Jul 8, 2025
800512a
Merge branch 'develop' into fb_customizeView53197
cnathe Jul 8, 2025
74afdfa
Merge branch 'develop' into fb_customizeView53197
cnathe Jul 9, 2025
af9ed0f
CR feedback: apply encodeURI in BaseTabs
cnathe Jul 9, 2025
2b0afdb
Merge branch 'develop' into fb_customizeView53197
cnathe Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/webapp/internal/ViewDesigner/FieldMetaStore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Ext4.define('LABKEY.internal.ViewDesigner.FieldMetaTreeStore', {
type: 'json',
root: 'columns',
idProperty: function(json) {
return json.fieldKeyPath.toUpperCase();
return encodeURI(json.fieldKeyPath.toUpperCase()); // Issue 53197
}
}
};
Expand Down Expand Up @@ -92,7 +92,7 @@ Ext4.define('LABKEY.internal.ViewDesigner.FieldMetaStore', {
type: 'json',
root: 'columns',
idProperty: function(json) {
return json.fieldKeyPath.toUpperCase();
return encodeURI(json.fieldKeyPath.toUpperCase()); // Issue 53197
}
}
};
Expand All @@ -109,7 +109,7 @@ Ext4.define('LABKEY.internal.ViewDesigner.FieldMetaStore', {
getById : function(id) {
var _id;
if (Ext4.isString(id)) {
_id = id.toUpperCase();
_id = encodeURI(id.toUpperCase()); // Issue 53197
}
else {
_id = id;
Expand Down
8 changes: 4 additions & 4 deletions core/webapp/internal/ViewDesigner/tab/BaseTab.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ Ext4.define('LABKEY.internal.ViewDesigner.model.FieldKey', {
mapping: 'fieldKey',
convert : function(fieldKey, rec) {
if (Ext4.isString(fieldKey)) {
return fieldKey.toUpperCase();
return encodeURI(fieldKey.toUpperCase()); // Issue 53197
}

if (rec && rec.raw && Ext4.isString(rec.raw.fieldKey)) {
return rec.raw.fieldKey.toUpperCase();
return encodeURI(rec.raw.fieldKey.toUpperCase()); // Issue 53197
}

throw new Error('LABKEY.internal.ViewDesigner.model.FieldKey: unable to generate id due to missing fieldKey.');
Expand All @@ -30,7 +30,7 @@ Ext4.define('LABKEY.internal.ViewDesigner.model.FieldKey', {
getById: function(id) {
var _id;
if (Ext4.isString(id)) {
_id = id.toUpperCase();
_id = encodeURI(id.toUpperCase()); // Issue 53197
}
else {
_id = id;
Expand All @@ -51,7 +51,7 @@ Ext4.define('LABKEY.internal.ViewDesigner.store.FieldKey', {
getById: function(id) {
var _id;
if (Ext4.isString(id)) {
_id = id.toUpperCase();
_id = encodeURI(id.toUpperCase()); // Issue 53197
}
else {
_id = id;
Expand Down