Skip to content

Issue 53431: Data Class and Sample Type data doesn't round-trip via folder export/import for field names with special char #6838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cnathe wants to merge 2 commits into from
Closed

Issue 53431: Data Class and Sample Type data doesn't round-trip via folder export/import for field names with special char #6838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a9ac8a
Issue 53431: Data Class and Sample Type data doesn't round-trip via f…
cnathe Jul 11, 2025
8abc4ae
PlateManager.exportPlateData to use ColumnHeaderType.ImportField
cnathe Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assay/src/org/labkey/assay/plate/PlateManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3764,7 +3764,7 @@ public List<PlateFileBytes> exportPlateData(Container c, User user, ContainerFil
try (TSVGridWriter writer = new TSVGridWriter(plateQueryView::getResults, displayColumns, Collections.singletonMap(sampleIdNameFieldKey.toString(), "Sample ID")))
{
writer.setDelimiterCharacter(delim);
writer.setColumnHeaderType(ColumnHeaderType.FieldKey);
writer.setColumnHeaderType(ColumnHeaderType.ImportField); // Issue 53431
writer.write(plateFileBytes.bytes);
}

Expand Down
2 changes: 1 addition & 1 deletion experiment/src/org/labkey/experiment/samples/AbstractExpFolderWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ protected void writeTsv(TableInfo tinfo, Collection<ColumnInfo> columns, SimpleF
try (TSVGridWriter tsvWriter = new TSVGridWriter(factory))
{
tsvWriter.setApplyFormats(false);
tsvWriter.setColumnHeaderType(ColumnHeaderType.FieldKey);
tsvWriter.setColumnHeaderType(ColumnHeaderType.ImportField); // Issue 53431
PrintWriter out = dir.getPrintWriter(baseName + ".tsv");
tsvWriter.write(out);
}
Expand Down