Skip to content

Issue 53536: LKSM/LKB: Moving assay runs with multiple file fields may populate file fields incorrectly #6881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XingY merged 1 commit into from
Jul 30, 2025
Merged

Issue 53536: LKSM/LKB: Moving assay runs with multiple file fields may populate file fields incorrectly #6881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions api/src/org/labkey/api/assay/AbstractAssayProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2169,10 +2169,11 @@ private void updateResultFiles(FilteredTable assayResultTable, List<ExpRun> runs
Map<Integer, ExpRun> runMap = new HashMap<>();
runs.forEach(run -> runMap.put(run.getRowId(), run));

Map<String, AssayFileMoveReference> fileMoveReferences = new HashMap<>();
Map<String, List<Integer>> fileMoveResultRowIds = new HashMap<>();
for (String fileField : fileFields)
{
Map<String, AssayFileMoveReference> fileMoveReferences = new HashMap<>();
Map<String, List<Integer>> fileMoveResultRowIds = new HashMap<>();

var fileColumn = assayResultTable.getColumn(fileField);
TableSelector ts = new TableSelector(assayResultTable, assayResultTable.getColumns("rowid", "run", fileField), filter, null);
Map<String, Object>[] resultFiles = ts.getMapArray();
Expand Down