Conversation
labkey-nicka
requested review from
labkey-nicka
and removed request for
labkey-susanh
labkey-nicka
approved these changes
Sep 9, 2025
| @Override | ||
| public void queryChanged(User user, Container container, ContainerFilter scope, SchemaKey schema, @NotNull QueryProperty property, @NotNull Collection<QueryPropertyChange<?>> changes) | ||
| { | ||
| if (!property.equals(QueryProperty.SchemaName) && !property.equals(QueryProperty.Name)) // Issue 53846 |
Contributor
There was a problem hiding this comment.
nit: I tend to practice doing enumerated equivalency checks the other way around to avoid potential NPE. I see that this property is annotated as @NotNull.
if (!QueryProperty.SchemaName.equals(property) && !QueryProperty.Name.equals(property)) // Issue 53846
return;| ExpSampleType sampleType = options.getRowId() >= 0 ? ss.getSampleType(options.getRowId()) : null; | ||
| Domain stDomain = sampleType != null ? sampleType.getDomain() : null; | ||
| Set<String> reservedNames = new CaseInsensitiveHashSet(this.getReservedPropertyNames(stDomain, user)); | ||
| reservedNames.add("Parent"); // Issue 52627: Don't allow "Parent" to be used for lineage parent import alias |
Contributor
There was a problem hiding this comment.
Surprises me that "Parent" isn't already a reserved name in general.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Issue 53771: Sample Manager: file absolute path revealed in sample timeline details
Issue 52627: Don't allow "Parent" to be used for lineage parent import alias
Issue 53846: Character limit on query property limit throws unhandled exception
Related Pull Requests
Changes
Tasks 📍