Filter signed snapshots based on notebook filter#7207
Merged
labkey-adam merged 9 commits intorelease25.11-SNAPSHOTfrom Nov 19, 2025
Merged
Filter signed snapshots based on notebook filter#7207labkey-adam merged 9 commits intorelease25.11-SNAPSHOTfrom
labkey-adam merged 9 commits intorelease25.11-SNAPSHOTfrom
Conversation
labkey-adam
requested review from
labkey-jeckels,
labkey-klum and
labkey-matthewb
| // Use in cases where the default temp schema won't do, e.g., you need to apply a large IN clause in an external data source | ||
| public SQLFragment appendInClauseSql(SQLFragment sql, @NotNull Collection<?> params, InClauseGenerator tempTableGenerator) | ||
| // Use only in cases where the default temp-table generator won't do, e.g., you need to apply a large IN clause in an external data source | ||
| public SQLFragment appendInClauseSqlWithCustomInClauseGenerator(SQLFragment sql, @NotNull Collection<?> params, InClauseGenerator tempTableGenerator) |
Contributor
There was a problem hiding this comment.
tempTableGenerator not used?
Contributor
Author
There was a problem hiding this comment.
In the default case, no... we don't create temp tables for every dialect (our support for some databases is read-only, e.g.). Providing a custom generator is implemented only for PostgreSQL because that's all I needed. But I certainly can (and will) clean this up in a follow-on PR.
labkey-klum
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Reintroduce
MigrationTableHandler, allowing LabBook to filter thecompliance.SignedSnapshottableInClauseoption to take a temp tableInClauseGeneratorExclude assay experiment runs in the assay-skip containers
Copy
core.Documentsrows in the background