Conversation
labkey-nicka
approved these changes
May 14, 2025
| { | ||
| try | ||
| { | ||
| return parseInt(getLogColumnValue(rowEntry, columnName)); |
Contributor
There was a problem hiding this comment.
This doesn't need to be wrapped with try/catch since getLogColumnValue will not throw a JSONException.
That said, I don't see getLogColumnValue throwing JSONException either. Did you change the implementation but leave theses try/catch wrappers?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
add selenium tests to check for domain and property audit comment updates
Related Pull Requests
Changes
SMSourceTypeUpdateTest.testUpdateDesignWithTrickyCharacters
ListTest.doRenameFieldsTest
SMProCalculatedColumnsDesignerTest.testUpdateAssayDesign/testFormattingOptions
adding/renaming/remove/update calculated fields
update calculated field formats
StudyDatasetTest.deleteFields
Import template: BiologicsDataClassTest.verifyRegistryCustomImportTemplates
AuditLogTest.testDomainPropertyEvents (list)
SMProAssayUpdateWithCommentsTest.createAssayData
TextChoiceSampleTypeTest.testSetTextChoiceValueForSample
SMSourceTypeCreateTest.testParentImportAliases
multiple domains (run vs result) for assay design
Import/parent alias
SMCustomizedIdentifyingFieldsTest.verifyAncestorFieldsDerivingFromSamplesAndSourcesFuzzTest
SampleTypeParentColumnTest.testUseThenRemoveAnAliasParentColumn/testAliasNameConflictsWithFieldName
genId update / reset
SampleTypeNameExpressionTest.testSetAndResetOfGenId
add barcode field (after providing user comment)
SMUserSuppliedBarcodeTest.testSampleTypeUpdateWithUniqueId (via clicking button)
SMSampleCreateTest.testCreateAndUpdateWithUniqueIdField (via adding Barcode field manually)
demographics fields
visit/timepoint fields