Skip to content

Improve synchronization of ParentEntityEditPanel#2669

Merged
labkey-tchad merged 3 commits intorelease25.9-SNAPSHOTfrom
25.9_fb_entityPanelEditTiming
Sep 8, 2025
Merged

Improve synchronization of ParentEntityEditPanel#2669
labkey-tchad merged 3 commits intorelease25.9-SNAPSHOTfrom
25.9_fb_entityPanelEditTiming

Conversation

@labkey-tchad
Copy link
Member

@labkey-tchad labkey-tchad commented Sep 4, 2025

Rationale

SMProLimitedReadTest.testTimelineView has been failing intermittently with audit log mismatches. Presumably, the problem is that the test is failing to actually make the expected changes. Adding some extra synchronization to ensure that the expected audit events have actually happened.

org.junit.ComparisonFailure: New value for second parent change not as expected expected:<[TS_1, TS_2]> but was:<[NA]>
  at org.junit.Assert.assertEquals(Assert.java:117) ~[junit-4.13.2.jar:4.13.2]
  at org.labkey.test.util.DeferredErrorCollector.lambda$5(DeferredErrorCollector.java:248) [uiTest/:?]
  at org.labkey.test.util.DeferredErrorCollector.wrapAssertion(DeferredErrorCollector.java:188) [uiTest/:?]
  at org.labkey.test.util.DeferredErrorCollector.verifyEquals(DeferredErrorCollector.java:248) [uiTest/:?]
  at org.labkey.test.tests.samplemanagement.userAndPermissions.SMProLimitedReadTest.testTimelineView(SMProLimitedReadTest.java:178) [uiTest/:?]

Related Pull Requests

Changes

  • Improve synchronization of ParentEntityEditPanel

@labkey-tchad labkey-tchad force-pushed the 25.9_fb_entityPanelEditTiming branch from 47bdae2 to 74371d8 Compare September 4, 2025 00:51
@labkey-tchad labkey-tchad merged commit 0d1ba00 into release25.9-SNAPSHOT Sep 8, 2025
6 checks passed
@labkey-tchad labkey-tchad deleted the 25.9_fb_entityPanelEditTiming branch September 8, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants