Skip to content

Conversation

pbrooks100
Copy link

After my first pass of just adding Salesforce, I found that I had broken other apps. I have now tested Google, Salesforce, LinkedIn, and GitHub with PKCE.

The web apps I created were all specifically created to test this library. The examples I submitted contain default client_id and client_secret values that are of no concern. I can also add up to 9 users for the Salesforce app (on request).

francois-normandin and others added 6 commits April 30, 2022 14:19
Added Salesforce and updated to use PKCE Auth Code
PKCE support required adding NI SHA-256 function (LV 2020) and Base64URL encode VI

Tested refresh_token support with Google API.
@francois-normandin
Copy link
Member

FYI. @pbrooks100 I published the base64 url update with OpenSerializer addon.

I'll ask the annoying question: Can you port your changes to LV2013? It should prevent mass-compile of the entire project. It is difficult to diff/review with 600 files changed. I assume only 10-20 files are actually impacted by your changes.

@francois-normandin
Copy link
Member

I seem to be missing a file.
image

And although the project was saved in 2017, there are also files saved in 2019 and 2020.
image

@francois-normandin
Copy link
Member

You can checkout the latest develop branch in which I ported the SHA256 hash to LV2013, which will be needed for PKCE.

image

@pbrooks100
Copy link
Author

pbrooks100 commented May 28, 2025

FYI. @pbrooks100 I published the base64 url update with OpenSerializer addon.

I'll ask the annoying question: Can you port your changes to LV2013? It should prevent mass-compile of the entire project. It is difficult to diff/review with 600 files changed. I assume only 10-20 files are actually impacted by your changes.

I'm using LabVIEW 2024 Community Edition; the earliest file version supported is 2017. I think my use of the LabVIEW native hash function caused one or two files to be save as 2020 (function added by NI in that version).

@francois-normandin
Copy link
Member

@pbrooks100 I understand that I'm still clinging to very old version support.
I'll take on me too back port your contribution. I'll ping you if I'm unsuccessful.

Again, thanks for these additions. I look forward to releasing them!

pbrooks100 and others added 5 commits May 30, 2025 13:28
Added Salesforce and updated to use PKCE Auth Code
PKCE support required adding NI SHA-256 function (LV 2020) and Base64URL encode VI

Tested refresh_token support with Google API.
@pbrooks100 pbrooks100 force-pushed the feature/Salesforce branch from 6fbe9c6 to 489ee09 Compare June 12, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants