Mi primer Code Review Yeraldin Casas #21
Open
YeraldinCasas wants to merge 13 commits intoLaboratoria:masterfrom
Open
Mi primer Code Review Yeraldin Casas #21YeraldinCasas wants to merge 13 commits intoLaboratoria:masterfrom
YeraldinCasas wants to merge 13 commits intoLaboratoria:masterfrom
Conversation
HectorBlisS
suggested changes
Feb 11, 2020
HectorBlisS
left a comment
HectorBlisS
left a comment
There was a problem hiding this comment.
Tienes un gran progreso, aunque tu JavaScript aún está un poquito disperso, si aún no comprendes al 100% cómo escribir en JavaScript o no te sientes con suficiente confianza; intenta resolver algunas katas o retos de JavaScript que te ayuden a practicar. Hay muy buenos aquí:
https://www.hackerrank.com/
src/cipher.js
Outdated
| @@ -1,5 +1,18 @@ | |||
| const cipher = { | |||
| // ... | |||
| const cipher = { cipher.encode | |||
src/cipher.js
Outdated
Comment on lines
+7
to
+16
| function cipher(string) = { | ||
| let string= " " | ||
| for = (let i= 0; i < string.length; i++) { | ||
| let numberLetter = string.charCodeAt (i); | ||
| let cipherFormula; | ||
| let newLetter; | ||
| if (numberLetter >= 65 && numberLetter <= 90); | ||
| cipherFormula = ( numberLetter - 65 + 33) % 26 + 65; | ||
| theNewLetter = String.fromCharCode(cipherFormula); | ||
| } |
There was a problem hiding this comment.
Recuerda que el cipher es un objeto con 2 llaves .encode y .decode, esas son las funciones, mientras que cipher es el objeto:
let cipher = {
encode(){},
decode(){}
}
src/style.css
Outdated
Comment on lines
+10
to
+21
| h1, h2 { | ||
| font-family: 'Caveat', cursive; | ||
| background: darkblue; | ||
| text-align: center; | ||
| color: white | ||
| } | ||
|
|
||
| h1 { | ||
| font-size: 60px; | ||
| } | ||
|
|
||
| p { |
There was a problem hiding this comment.
Intenta crear más clases en vez de seleccionar los elementos directamente, es mejor practica aunque es un poco más de trabajo, al final es el standard ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Se trabajó HTML y CSS, apenasestoy intentando con JS y no tengo idea como empezar.