Jimena Manzanares - Primer code review#27
Open
JimenaMV wants to merge 5 commits intoLaboratoria:masterfrom
Open
Jimena Manzanares - Primer code review#27JimenaMV wants to merge 5 commits intoLaboratoria:masterfrom
JimenaMV wants to merge 5 commits intoLaboratoria:masterfrom
Conversation
AdrianaHY
reviewed
Feb 14, 2020
| OFRECEMOS productos chinamperos y de la zona de montaña libres de agroquímicos y de la más alta calidad | ||
| UNIMOS a consumidores y productores de forma directa al no haber intermediarios | ||
| IMPULSAMOS la incorporación de nuevos productores chinamperos y productos de la zona de montaña para hacer crecer a nuestra comunidad | ||
| </p> |
AdrianaHY
reviewed
Feb 14, 2020
src/index.html
Outdated
| OFRECEMOS productos chinamperos y de la zona de montaña libres de agroquímicos y de la más alta calidad | ||
| UNIMOS a consumidores y productores de forma directa al no haber intermediarios | ||
| IMPULSAMOS la incorporación de nuevos productores chinamperos y productos de la zona de montaña para hacer crecer a nuestra comunidad | ||
| </p> |
AdrianaHY
reviewed
Feb 14, 2020
src/index.html
Outdated
| <p> | ||
| Canasta con tres hortalizas | ||
| <br> | ||
| 2 cupones |
There was a problem hiding this comment.
Evita utilizar br, puedes agregar estilos con CSS
AdrianaHY
reviewed
Feb 14, 2020
src/index.js
Outdated
| @@ -1,3 +1,11 @@ | |||
| import cipher from './cipher.js'; | |||
|
|
|||
| console.log(cipher); | |||
There was a problem hiding this comment.
Toda tu lógica va a partir de la línea 2 :)
AdrianaHY
reviewed
Feb 14, 2020
AdrianaHY
left a comment
AdrianaHY
left a comment
There was a problem hiding this comment.
Muy buen avance, te recomiendo optimizar tus imagenes para que no sean tan pesadas! :)
AdrianaHY
reviewed
Feb 15, 2020
| //decode ("C",2); | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Creo que en general vas bastante bien! pero hay una cosa que aun debes solucionar, encode y decode van dentro de cipher.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hice el maquetado en HTML, y ahora estoy con los inputs para asignar un valor a cada producto.