Guardando primer cambio Natalia Olmos#36
Open
NataliaOlmos wants to merge 19 commits intoLaboratoria:masterfrom
Open
Guardando primer cambio Natalia Olmos#36NataliaOlmos wants to merge 19 commits intoLaboratoria:masterfrom
NataliaOlmos wants to merge 19 commits intoLaboratoria:masterfrom
Conversation
AdrianaHY
reviewed
Feb 13, 2020
src/cifrar.html
Outdated
| </head> | ||
| <div align="center"><h1>CIFRAR</h1> | ||
| <script src="cifrar.js"></script> | ||
| </head> |
Author
There was a problem hiding this comment.
Gracias Adriana!!! lo tomaré en cuenta!! :)
AdrianaHY
reviewed
Feb 13, 2020
src/cifrar.html
Outdated
| <script src="cifrar.js"></script> | ||
| </head> | ||
| <body> | ||
| <div align="center"><p>Introduce el texto y número de desplazamientos para comenzar</p> |
There was a problem hiding this comment.
Sugiero que el acomodo de los elementos, así como los estilos vayan en el CSS
AdrianaHY
reviewed
Feb 13, 2020
src/cifrar.html
Outdated
| <body> | ||
| <div align="center"><p>Introduce el texto y número de desplazamientos para comenzar</p> | ||
| <div align="center"><p>Texto:</p><form name="formulario1"> | ||
| <textarea placeholder="Escribe aquí el texto..." type="text1" name="caja1" value="" size=20 cols="75" rows="7"></textarea> |
AdrianaHY
reviewed
Feb 13, 2020
src/cifrar.html
Outdated
| <div align="center"> <p>Número desplazamientos:</p><form name="desplazar" method="post" action="mostrarMensaje"> | ||
| <!-- Lista de selección --> | ||
| <div align="center"><select name="combo"> | ||
| <!-- Opciones de la lista --> |
There was a problem hiding this comment.
Recordemos que los comentarios solo cuando sean necesarios, esto es bastante explícito.
AdrianaHY
reviewed
Feb 13, 2020
src/cifrar.html
Outdated
| </select> | ||
| </form> | ||
| <div align="center"><input type="button" value="cifrar" onclick="decodificar()"></p> | ||
|
|
AdrianaHY
reviewed
Feb 13, 2020
src/descifrar.html
Outdated
| </head> | ||
| <div align="center"><h1>DESCIFRAR</h1> | ||
| <script src="cifrar.js"></script> | ||
| </head> |
AdrianaHY
reviewed
Feb 13, 2020
src/descifrar.html
Outdated
| <link href="styledescifrar.css" rel="stylesheet" type="text/css"/> | ||
| </head> | ||
| <div align="center"><h1>DESCIFRAR</h1> | ||
| <script src="cifrar.js"></script> |
There was a problem hiding this comment.
La indentación y legibilidad es bien importante, procura tener consistencia.
AdrianaHY
reviewed
Feb 13, 2020
src/stylecifrar.css
Outdated
| @@ -0,0 +1,16 @@ | |||
| body { background-color: #F7F07B; | |||
| position: absolute; | |||
There was a problem hiding this comment.
Hay que aplicar buenas prácticas, este código no es tan legible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.