Code Review Squad 3 Laura V Bailon M#44
Open
9JazzCodeLBM wants to merge 20 commits intoLaboratoria:masterfrom
Open
Code Review Squad 3 Laura V Bailon M#449JazzCodeLBM wants to merge 20 commits intoLaboratoria:masterfrom
9JazzCodeLBM wants to merge 20 commits intoLaboratoria:masterfrom
Conversation
AdrianaHY
reviewed
Feb 15, 2020
| const decipher = { | ||
| // ... | ||
| }; | ||
|
|
There was a problem hiding this comment.
Esta parte que hace? por qué la pusimos?
AdrianaHY
reviewed
Feb 15, 2020
AdrianaHY
left a comment
AdrianaHY
left a comment
There was a problem hiding this comment.
Muy buen avance! solo hay que poner atención en los objetos de cipher, no son necesarios ambos, tienes tu objeto cipher y dentro lleva las dospropiedades: encode y decode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
¡Hola Adri !
Envío mi primer PULL REQUEST, avances de html y css, sigo trabajando con JS.
Use las etiquetas de HTML5 para estructurar mis archivos.
De antemano, gracias por la revisión.
Atte. Laura V. Bailón M.