Skip to content

Feature/wallet integrations#171

Closed
emdevelopa wants to merge 10 commits intoLabsCrypt:mainfrom
emdevelopa:feature/wallet-integrations
Closed

Feature/wallet integrations#171
emdevelopa wants to merge 10 commits intoLabsCrypt:mainfrom
emdevelopa:feature/wallet-integrations

Conversation

@emdevelopa
Copy link
Copy Markdown
Contributor

Description

Finalize production-ready wallet integrations for Freighter, Albedo, and xBull. This PR removes mock sessions, implements real authentication flows, handles user rejections, and ensures consistent network and account display across the app.

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔧 Refactoring (no functional changes)
  • ⚡ Performance improvement
  • 🧪 Test addition or update

Related Issues

Closes #129
fixes #129

Changes Made

  • Removed mock fallback for Freighter in production.
  • Implemented real web authentication flow for Albedo.
  • Added mobile wallet handoff support for xBull.
  • Display wallet network and public key in the UI.
  • Ensured backend queries and contract calls respect selected network.
  • Added user-friendly wallet error messages.

Testing

  • Connected and disconnected Freighter, Albedo, and xBull wallets manually.
  • Verified network selection affects backend queries correctly.
  • Checked proper display of wallet public key and network in the UI.

Test Coverage

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed

Test Steps

  1. Open app and connect Freighter wallet.
  2. Switch network and verify backend queries match selected network.
  3. Repeat steps with Albedo and xBull wallets, including mobile handoff for xBull.
  4. Trigger error scenarios (user rejects connection) and verify friendly messages.

Breaking Changes

Breaking Changes:

  • None

Migration Guide:

  • No migration required.

Screenshots/Demo

  • Wallet connection flow and network/account display verified on all devices.

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published
  • I have checked for breaking changes and documented them if applicable

Additional Notes

  • Ensure mobile testing for xBull wallet handoff is performed before merging.

Copy link
Copy Markdown
Contributor

@ogazboiz ogazboiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey! thanks for creating a dedicated feature branch for this.

the CI is currently failing on the "Dependency Vulnerability Scan" and "CodeQL" steps. could you check the GitHub Actions logs under the "Checks" tab and see if there are any critical package updates or issues that need patching?

once CI goes green, we can get this merged!

@emdevelopa
Copy link
Copy Markdown
Contributor Author

@ogazboiz fixed

@ogazboiz
Copy link
Copy Markdown
Contributor

closing because PR #163 (Production ready wallet integrations) has been successfully merged and covers these changes! thanks again for getting this feature across the finish line.

@ogazboiz ogazboiz closed this Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Epic: Production ready wallet integrations

2 participants