Skip to content

Add github workflow#28

Open
AkiSakurai wants to merge 1 commit intoLaidout:masterfrom
AkiSakurai:ci
Open

Add github workflow#28
AkiSakurai wants to merge 1 commit intoLaidout:masterfrom
AkiSakurai:ci

Conversation

@AkiSakurai
Copy link
Copy Markdown
Contributor

I have translated Travis config to Github workflow.

It now produces both AppImage and macOS tar executable.

On push to master branch, also create release with tag gh_continous.

On push to tag with version format, also create releases with debian:stable/ubuntu:jammy .deb.

Sample release:
https://github.com/AkiSakurai/laidout/releases

Deb is not signed.

Produce AppImage and macOS tar executable.
On push to master branch, also create release with tag gh_continous.
On push to tag with version format, also create releases with debian:stable/ubuntu:jammy .deb.
@tomlechner
Copy link
Copy Markdown
Contributor

Looking good! I'll probably have time to dig into it more after the weekend.
If you're interested, it would be nice to debug flatpak generation too (#21)!

@tomlechner
Copy link
Copy Markdown
Contributor

Finally had some time to go over this some more..
On the whole looks good. Makes me a little nervous to depend on two external actions from people I'm not familiar with using repos that I have no control over that get access to my GITHUB_TOKEN:

Not necessarily a deal breaker, I just have to make sure I understand what's in those actions,
plus I need to read a bit more about security of GITHUB_TOKENs.

@AkiSakurai
Copy link
Copy Markdown
Contributor Author

You are quite right, I didn't realize there is potential security problem.

The actions are picked from recommendations from deprecated official action, I don't think they are reviewed by github staff though.
https://github.com/actions/create-release

There is another action maintained by google, presumably be more trustworthy and well maintained.
https://github.com/google-github-actions/release-please-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants