Fix: systemuicontroller warning during build #219
Closed
praveenxsharma wants to merge 26 commits intoLambada10:masterfrom
Closed
Fix: systemuicontroller warning during build #219praveenxsharma wants to merge 26 commits intoLambada10:masterfrom
praveenxsharma wants to merge 26 commits intoLambada10:masterfrom
Conversation
removing the Accompanist SystemUI Controller because Google stopped supporting it
Removed the version reference for accompanist-systemuicontroller.
Author
This was the build warning |
Updated the base URL for fetching Spotify lyrics and changed the parameter from 'url' to 'id'.
Updated CI workflow to use actions/checkout@v4 and modified conditions for release build.
Initialize user settings controller and lyrics provider service in the application.
Removed userSettingsController from QuickLyricsSearchActivity.
Added a function to check if a song has lyrics by verifying the presence of an .lrc file or embedded lyrics.
Updated filterSongs function to accept context as a parameter for better access to application resources.
Updated formatLineLyrics to clean text by removing timestamps.
Added regex for lyrics cleanup and improved formatting logic for syllable lyrics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
System UI Controller is deprecated by google , so removed