fix: decode HTML entities in Netease lyrics (#216)#225
Closed
VishvasJadav wants to merge 1 commit intoLambada10:masterfrom
Closed
fix: decode HTML entities in Netease lyrics (#216)#225VishvasJadav wants to merge 1 commit intoLambada10:masterfrom
VishvasJadav wants to merge 1 commit intoLambada10:masterfrom
Conversation
|
Could this post processing be carried out in a common utility function for better maintainability? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #216
Problem
Lyrics fetched from the Netease provider sometimes contain HTML encoded
special characters (e.g.
äinstead ofä,üinstead ofü,ßinstead ofß).This was reported when viewing lyrics for the song "Kein Alkohol (Ist auch
keine Lösung)!" by Die Toten Hosen from Netease.
Solution
Added HTML entity decoding to
NeteaseAPI.getSyncedLyrics()usingHtmlCompat.fromHtml()from AndroidX Core (already a project dependency).The decoding is applied line-by-line to preserve the LRC timestamp format
— since
Html.fromHtml()treats newlines as whitespace (standard HTMLbehavior), processing each line individually ensures timestamps like
[00:15.00]and line breaks remain intact.Changes
decodeHtmlEntities()private helper inNeteaseAPIgetSyncedLyrics()androidx.core:core-ktx)Testing
ä,ü,ßdisplay correctly