Skip to content

Refactor upload success logging to unify message display regardless of progress tracking #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2025
Merged

Refactor upload success logging to unify message display regardless of progress tracking #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 9 additions & 14 deletions src/main/java/io/github/lambdatest/gradle/LambdaTestTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,28 +91,23 @@ public void runLambdaTest() {
try {
if (appIdFuture != null) {
appId = appIdFuture.join();
if (!progressEnabled) {
logger.info("App uploaded successfully with ID: {}", appId);
}
}

if (testSuiteIdFuture != null) {
testSuiteId = testSuiteIdFuture.join();
if (!progressEnabled) {
logger.info("Test suite uploaded successfully with ID: {}", testSuiteId);
}
}

// Clear progress display if enabled
// Clear progress display if enabled, then show success messages
if (progressEnabled) {
ProgressTracker.cleanup();
// Show success messages after progress cleanup
if (appIdFuture != null) {
logger.info("App uploaded successfully with ID: {}", appId);
}
if (testSuiteIdFuture != null) {
logger.info("Test suite uploaded successfully with ID: {}", testSuiteId);
}
}

// Show success messages (unified flow for both progress and non-progress cases)
if (appIdFuture != null) {
logger.info("App uploaded successfully with ID: {}", appId);
}
if (testSuiteIdFuture != null) {
logger.info("Test suite uploaded successfully with ID: {}", testSuiteId);
}
} catch (CompletionException e) {
// Cleanup progress display on error
Expand Down
31 changes: 11 additions & 20 deletions src/main/java/io/github/lambdatest/gradle/LambdaUploaderTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,34 +59,25 @@ public void uploadApkToLambdaTest() {
try {
if (appIdFuture != null) {
appId = appIdFuture.join();
if (!progressEnabled) {
logger.lifecycle(
"\u001B[32mApp uploaded successfully with ID: {}\u001B[0m", appId);
}
}

if (testSuiteIdFuture != null) {
testSuiteId = testSuiteIdFuture.join();
if (!progressEnabled) {
logger.lifecycle(
"\u001B[32mTest suite uploaded successfully with ID: {}\u001B[0m",
testSuiteId);
}
}

// Clear progress display if enabled
// Clear progress display if enabled, then show success messages
if (progressEnabled) {
ProgressTracker.cleanup();
// Show success messages after progress cleanup
if (appIdFuture != null) {
logger.lifecycle(
"\u001B[32mApp uploaded successfully with ID: {}\u001B[0m", appId);
}
if (testSuiteIdFuture != null) {
logger.lifecycle(
"\u001B[32mTest suite uploaded successfully with ID: {}\u001B[0m",
testSuiteId);
}
}

// Show success messages (unified flow for both progress and non-progress cases)
if (appIdFuture != null) {
logger.lifecycle("\u001B[32mApp uploaded successfully with ID: {}\u001B[0m", appId);
}
if (testSuiteIdFuture != null) {
logger.lifecycle(
"\u001B[32mTest suite uploaded successfully with ID: {}\u001B[0m",
testSuiteId);
}
} catch (CompletionException e) {
// Cleanup progress display on error
Expand Down
Loading