Support for custom timestamps via XML attributes#72
Open
N4gtan wants to merge 12 commits intoLameguy64:masterfrom
Open
Support for custom timestamps via XML attributes#72N4gtan wants to merge 12 commits intoLameguy64:masterfrom
N4gtan wants to merge 12 commits intoLameguy64:masterfrom
Conversation
Files and subdirectories now automatically inherit the base path from their parent entry. This allows omitting the `source` attribute, as paths will be resolved relative to the current directory context.
This introduces the `date` attribute in the XML schema. - dumpsxiso: Exports the ISO file timestamps into the XML output. - mkpsxiso: Parses the date from the XML. If not present, it fallsback to the source file's timestamps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a
dateattribute to the XML schema, to preserve timestamps independently of the source files.Previously, modifying a file would change its timestamp in the generated ISO. This caused xdelta patches to grow unnecessarily because the filesystem metadata changed even if the file content change was minimal.
By allowing fixed dates in the XML, this feature simulates a "file injection" behavior, keeping timestamps consistent and ensuring that binary patches only reflect actual data changes.
Additionally, this bypasses the filesystem limitations on
ext4andxfs, where dates older than December 1901 could not be represented correctly.This PR depends on: