-
Notifications
You must be signed in to change notification settings - Fork 6
Migrate from Create React App to Vite #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
f447687
fe47878
3af67a1
63edc16
60ac98c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| import React, { FC } from 'react' | ||
| import { createStyles, makeStyles, Theme } from '@material-ui/core/styles' | ||
| import { ReactComponent as ProjectLogo } from '../../img/logo.svg' | ||
| import ProjectLogo from '../../img/logo.svg?react' | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggestion, not related to this pr, but TS does have a nice way to use absolute imports so we're not stuck with lots of Just a wishlist thing for later though. |
||
|
|
||
| type LogoProps = { | ||
| darkTheme?: boolean | ||
|
|
||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same comment for here and the others, regarding Link -> Button |
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ankit0504 while this does work, I'd prefer to just use a legit solution since there are 6 instances of this.
I'm not sure why I used Link for this (maybe for styling?), but it's definitely not a link so let's go with Button (here and in the other 5 spots) unless you see any reason not to.