Use System.IO.Compression for decompressing PFS files#34
Open
anarelion wants to merge 1 commit intoLanternEQ:mainfrom
Open
Use System.IO.Compression for decompressing PFS files#34anarelion wants to merge 1 commit intoLanternEQ:mainfrom
anarelion wants to merge 1 commit intoLanternEQ:mainfrom
Conversation
Author
|
Web page showing the vulnerability and unmaintained status: https://www.nuget.org/packages/DotNetZip/1.16.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DotNetZip is considered vulnerable and unmaintained according to the linters in Visual Studio.
This PR updates the decompression function to use the facilities already provided by the language library.
For testing, I have successfully built and executed LanternExtractor, and as part of my own project (which I copied this function to) it works and loads assets.
It requires .NET version 6. I am not sure how to set this to the minimum.