Skip to content

Rewrite settings tabs for more readability#16

Closed
Ssionn wants to merge 1 commit intoLaravelDaily:mainfrom
Ssionn:settings-tabs
Closed

Rewrite settings tabs for more readability#16
Ssionn wants to merge 1 commit intoLaravelDaily:mainfrom
Ssionn:settings-tabs

Conversation

@Ssionn
Copy link
Copy Markdown
Contributor

@Ssionn Ssionn commented Jul 24, 2025

No images needed, looks the same, different code.

@PovilasKorop
Copy link
Copy Markdown
Collaborator

@Ssionn I don't know, I don't like the naming x-tab it's very generic. These things are not actually tabs, these are links. So maybe x-settings-link? But then you might want to use them elsewhere in the future, outside settings?

Not sure, in general I'm not a big fan of creating components that are used only on this one page and probably nowhere else.

For me personally, that <a class is readable, I don't see a problem here.

But thanks for the effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants