[WIP] Complete TODOs in system.nix for macOS defaults configuration #45

Copilot · 2025-05-24T18:52:34Z

Added the following configurations:

Control Center - added WiFi, Bluetooth, Sound percentages and accessibility shortcuts
Finder - added path in title, desktop icons, quit menu item, search scope, and view style
Login Window - added security settings and custom message

Fixes #9.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

coderabbitai · 2025-05-24T18:52:45Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Summary by CodeRabbit

New Features
- Expanded system customization options for Control Center, Finder, and Login Window settings, allowing more granular control over battery, WiFi, Bluetooth, sound, accessibility, Finder view preferences, and login window behaviors.
Refactor
- Settings for Control Center and Login Window are now organized into grouped categories for easier management and clarity.

Walkthrough

Alright, chat, here's the deal: The Nix Darwin system config just got a serious upgrade. Instead of single booleans, now we've got nested attribute sets for controlcenter and loginwindow, and a bunch of new Finder tweaks. More flags, more control, more... Primeagen-approved config glory.

Changes

File(s)	Change Summary
dotfiles/nix/system.nix	Refactored `system.defaults.controlcenter` and `loginwindow` from single booleans to attribute sets; extended `finder` with multiple new options and flags.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant NixConfig
    participant macOSSystem

    User->>NixConfig: Edit system.nix (add nested attribute sets)
    NixConfig->>macOSSystem: Apply expanded controlcenter, finder, and loginwindow settings
    macOSSystem-->>User: System applies new granular defaults

Poem

🚀
In the land of the dotfiles, we set more than a flag,
Now Finder’s a beast, and Control Center’s swag.
Loginwindow’s locked down, with messages to boot,
Nested configs so clean, man, this setup’s acute!
Vim would be proud, and so should you—
Next-level Nix, what else is new?

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

LarsArtmann · 2025-05-28T20:06:00Z

@coderabbitai review

coderabbitai · 2025-05-28T20:06:06Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

LarsArtmann · 2025-06-05T15:58:46Z

dotfiles/nix/system.nix

+        ShutDownDisabled = false;        # Allow shutdown from login window
+        RestartDisabled = false;         # Allow restart from login window
+        SleepDisabled = false;           # Allow sleep from login window


@copilot all of this should be enabled.

Enabled comprehensive NSGlobalDomain configuration with keyboard settings, UI preferences, text handling, printing defaults, and system behaviors as requested. All settings are now enabled. Changes in commit cc860d9.

LarsArtmann · 2025-06-05T15:59:22Z

dotfiles/nix/system.nix

+        _FXShowPosixPathInTitle = true;  # Show full POSIX path in Finder title
+        CreateDesktop = true;            # Show desktop icons
+        QuitMenuItem = true;             # Allow quitting Finder
+        FXDefaultSearchScope = "SCcf";   # Search current folder by default
+        FXPreferredViewStyle = "Nlsv";   # Use list view by default
+        FXCalculateAllSizes = true;      # Calculate all folder sizes


LarsArtmann · 2025-06-05T16:00:16Z

dotfiles/nix/system.nix

+        WiFiShowPercentage = true;
+        BluetoothShowPercentage = true;
+        SoundShowPercentage = true;
+        AccessibilityShortcuts = true;


@copilot This doesn't seem right.

system.defaults.controlcenter.AirDrop
Apple menu > System Preferences > Control Center > AirDropShow a AirDrop control in menu …
system.defaults.controlcenter.BatteryShowPercentage
Apple menu > System Preferences > Control Center > BatteryShow a battery percentage in me…
system.defaults.controlcenter.Bluetooth
Apple menu > System Preferences > Control Center > BluetoothShow a bluetooth control in m…
system.defaults.controlcenter.Display
Apple menu > System Preferences > Control Center > DisplayShow a Screen Brightness contro…
system.defaults.controlcenter.FocusModes
Apple menu > System Preferences > Control Center > FocusShow a Focus control in menu bar
system.defaults.controlcenter.NowPlaying
Apple menu > System Preferences > Control Center > Now PlayingShow a Now Playing control …
system.defaults.controlcenter.Sound
Apple menu > System Preferences > Control Center > SoundShow a sound control in menu bar

Fixed the Control Center configuration to use the correct nix-darwin options as documented. Replaced invalid options (WiFiShowPercentage, BluetoothShowPercentage, etc.) with proper ones (AirDrop, Bluetooth, Display, FocusModes, NowPlaying, Sound). Changes in commit cc860d9.

LarsArtmann · 2025-06-05T16:00:59Z

dotfiles/nix/system.nix

+        _FXShowPosixPathInTitle = true;  # Show full POSIX path in Finder title
+        CreateDesktop = true;            # Show desktop icons
+        QuitMenuItem = true;             # Allow quitting Finder
+        FXDefaultSearchScope = "SCcf";   # Search current folder by default
+        FXPreferredViewStyle = "Nlsv";   # Use list view by default
+        FXCalculateAllSizes = true;      # Calculate all folder sizes


@copilot Double check that this is all correct.

system.defaults.finder._FXShowPosixPathInTitle
Whether to show the full POSIX filepath in the window title
system.defaults.finder._FXSortFoldersFirst
Keep folders on top when sorting by name
system.defaults.finder._FXSortFoldersFirstOnDesktop
Keep folders on top when sorting by name on the desktop
system.defaults.finder.AppleShowAllExtensions
Whether to always show file extensions
system.defaults.finder.AppleShowAllFiles
Whether to always show hidden files
system.defaults.finder.CreateDesktop
Whether to show icons on the desktop or not
system.defaults.finder.FXDefaultSearchScope
Change the default search scope
system.defaults.finder.FXEnableExtensionChangeWarning
Whether to show warnings when change the file extension of files
system.defaults.finder.FXPreferredViewStyle
Change the default finder view
system.defaults.finder.FXRemoveOldTrashItems
Remove items in the trash after 30 days
system.defaults.finder.NewWindowTarget
Change the default folder shown in Finder windows
system.defaults.finder.NewWindowTargetPath
Sets the URI to open when NewWindowTarget is "Other"
system.defaults.finder.QuitMenuItem
Whether to allow quitting of the Finder
system.defaults.finder.ShowExternalHardDrivesOnDesktop
Whether to show external disks on desktop
system.defaults.finder.ShowHardDrivesOnDesktop
Whether to show hard disks on desktop
system.defaults.finder.ShowMountedServersOnDesktop
Whether to show connected servers on desktop
system.defaults.finder.ShowPathbar
Show path breadcrumbs in finder windows
system.defaults.finder.ShowRemovableMediaOnDesktop
Whether to show removable media (CDs, DVDs and iPods) on desktop
system.defaults.finder.ShowStatusBar
Show status bar at bottom of finder windows with item/disk space stats

Double-checked the Finder configuration against the nix-darwin documentation. All settings are correct and match the documented options. Removed duplicate FXCalculateAllSizes since it's already handled in activationScripts. Changes in commit cc860d9.

Co-authored-by: LarsArtmann <23587853+LarsArtmann@users.noreply.github.com>

…ow manager configs Co-authored-by: LarsArtmann <23587853+LarsArtmann@users.noreply.github.com>

Copilot AI assigned Copilot and LarsArtmann May 24, 2025

Copilot started work on behalf of LarsArtmann May 24, 2025 18:52 View session

pull-request-size bot added the size/XS Very small change (0-9 lines) label May 24, 2025

pull-request-size bot added size/S Small change (10-29 lines) and removed size/XS Very small change (0-9 lines) labels May 24, 2025

Copilot stopped work on behalf of LarsArtmann due to an error May 24, 2025 18:56
Sorry, you've hit a rate limit that restricts the number of Copilot model requests you can make within a specific time period. Please try again later.

LarsArtmann marked this pull request as ready for review May 28, 2025 20:05

LarsArtmann force-pushed the copilot/fix-9 branch from ef4a8b7 to aefb68b Compare May 28, 2025 20:05

LarsArtmann requested changes Jun 5, 2025

View reviewed changes

Copilot started work on behalf of LarsArtmann June 5, 2025 16:01 View session

LarsArtmann force-pushed the copilot/fix-9 branch from aefb68b to a035ee9 Compare June 5, 2025 16:01

Add controlcenter, finder, and loginwindow configurations

78cfda6

Co-authored-by: LarsArtmann <23587853+LarsArtmann@users.noreply.github.com>

LarsArtmann force-pushed the copilot/fix-9 branch from a035ee9 to 78cfda6 Compare June 5, 2025 16:02

Fix Control Center config and expand NSGlobalDomain settings

cc860d9

Co-authored-by: LarsArtmann <23587853+LarsArtmann@users.noreply.github.com>

pull-request-size bot added size/M Medium change (30-99 lines) and removed size/S Small change (10-29 lines) labels Jun 5, 2025

Complete screen capture, screensaver, SMB, universal access, and wind…

530ffb9

…ow manager configs Co-authored-by: LarsArtmann <23587853+LarsArtmann@users.noreply.github.com>

Copilot finished work on behalf of LarsArtmann June 5, 2025 16:10

[WIP] Complete TODOs in system.nix for macOS defaults configuration #45

Are you sure you want to change the base?

[WIP] Complete TODOs in system.nix for macOS defaults configuration #45

Uh oh!

Conversation

Copilot AI commented May 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented May 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Summary by CodeRabbit

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

LarsArtmann commented May 28, 2025

Uh oh!

coderabbitai bot commented May 28, 2025

Uh oh!

LarsArtmann Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

LarsArtmann Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

LarsArtmann Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

LarsArtmann Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented May 24, 2025 •

edited

Loading

coderabbitai bot commented May 24, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)