Skip to content

Conversation

@lasley
Copy link
Member

@lasley lasley commented Dec 16, 2016

Python CFSSL Library

This library allows you to interact with a remote CFSSL API using Python.

cc @t3ddftw @YannickB

Re https://github.com/clouder-community/clouder/pull/180#discussion_r92754615

@lasley lasley added this to the 0.1.0 milestone Dec 16, 2016
@lasley lasley requested a review from tedsalmon December 16, 2016 06:56
@lasley lasley force-pushed the feature/master/initial-library branch 3 times, most recently from 6ad3c46 to ec52190 Compare December 16, 2016 08:14
@codecov-io
Copy link

codecov-io commented Dec 16, 2016

Current coverage is 100% (diff: 100%)

Sunburst

Diff Coverage File Path
•••••••••• 100% new cfssl/exceptions.py
•••••••••• 100% new cfssl/cfssl.py

No coverage report found for master at 256c2af.

Powered by Codecov. Last update 256c2af...4bd298c

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ec5219066147679fa35ac0947beb7486be4543dc on feature/master/initial-library into ** on master**.

Copy link
Contributor

@tedsalmon tedsalmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus one detail :)

setup.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like you removed the need for xmlrunner when you switched to TextTestRunner from unittest. Is this still required?

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling fd9b0d30823e49d376a4bea97663e7c364ac7641 on feature/master/initial-library into ** on master**.

@lasley
Copy link
Member Author

lasley commented Dec 17, 2016

Fixed!@

@lasley lasley force-pushed the feature/master/initial-library branch from fd9b0d3 to 4bd298c Compare December 17, 2016 02:40
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4bd298c on feature/master/initial-library into ** on master**.

@lasley lasley dismissed tedsalmon’s stale review December 17, 2016 02:42

Comments attended to, build passing on changes + squash.

@lasley lasley merged commit 0770766 into master Dec 17, 2016
@lasley lasley deleted the feature/master/initial-library branch December 17, 2016 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants