modules/btop: fix unnecessary rebuilds when flake source changes#124
Open
adeci wants to merge 1 commit intoLassulus:mainfrom
Open
modules/btop: fix unnecessary rebuilds when flake source changes#124adeci wants to merge 1 commit intoLassulus:mainfrom
adeci wants to merge 1 commit intoLassulus:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
toStringon a path inside a flake gives you a string with the source tree hash baked in. So when you override.pathwith a nix path literal (like"btop.conf".path = ./btop.conf;), any change to any tracked file in the consuming flake rebuilds btop, even if the config file didn't change...String interpolation (
"${...}") instead oftoStringwill have nix content-address the file on its own, so the wrapper will only rebuild when the config actually changes. This sametoStringpattern exists in all the other modules too. Could also be fixed at the types.file level with an apply, but only keeping this scoped to btop for now.