modules/zsh: more settings to costumize completions#136
Merged
zimward merged 1 commit intoLassulus:mainfrom Feb 26, 2026
Merged
modules/zsh: more settings to costumize completions#136zimward merged 1 commit intoLassulus:mainfrom
zimward merged 1 commit intoLassulus:mainfrom
Conversation
Mrid22
force-pushed
the
better-completions
branch
from
e15044a to
af5f6e9
Compare
Mrid22
changed the title
zimward
reviewed
Feb 25, 2026
Collaborator
zimward
left a comment
zimward
left a comment
There was a problem hiding this comment.
generally looks fine, but the commit should start with module/zsh like in the other pr already mentioned. the idea is generally to follow nixpkgs' commit convention
New stuff: option for case insensitive completion option to add zsh-completions package for extra completions option to have color for file completions fzf tab support
Mrid22
force-pushed
the
better-completions
branch
from
af5f6e9 to
098bd27
Compare
Author
|
So im probably reading the test logs wrong somehow, but it looks like this failed because they all run as one action and the mpv check failed even though that module wasn't even updated in this pr? |
Collaborator
|
welcome to github where restarting a CI job three times in a row makes it go from red to green |
zimward
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New stuff:
option for case insensitive completion
option to add zsh-completions package for extra completions option to have color for file completions
option to add color to directory completions
option to integrate fzf-tab for fuzzy search completion