fix: upgrade path fallback, provider progress tracking#48
Merged
LavX merged 4 commits intodevelopmentfrom Mar 30, 2026
Merged
Conversation
…uard - When a subtitle file has been renamed or re-downloaded (e.g. .hu.hi.srt to .hu.srt), the upgrade system now finds the current file for the same language instead of silently dropping the candidate. - Fix time_until_midnight callers passing datetime instead of timezone (regression from upstream cherry-pick of 263d01c). - Guard against None score in forced_minimum_score to prevent TypeError on manual download history entries.
Show which provider is being searched in real-time in the jobs manager (e.g. "Searching opensubtitles (2/5)"). Adds a provider_progress_callback on the provider pool that gets called before each provider query. Both individual and specific subtitle searches now report progress.
The terminate/restart logic should not be inside finally, which runs even if os.remove fails, masking the exception.
Verify the scraper service is reachable during provider initialization by hitting /health. If unreachable, raise ServiceUnavailable so the provider is throttled for 20 minutes and shows the issue in System > Providers, instead of silently failing on every search.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.hu.hi.srtto.hu.srt), the upgrade system now finds the current file for the same language instead of silently dropping the candidatetime_until_midnightcallers were passingdatetimeinstead oftimezone(regression from upstream cherry-pick)Test plan