Skip to content

feat(cognito): add MfaSecondFactor support to CognitoUserPoolConstruct #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ncipollina merged 1 commit into from
Apr 4, 2026
Merged

feat(cognito): add MfaSecondFactor support to CognitoUserPoolConstruct #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project>
<PropertyGroup>
<VersionPrefix>2.2.0</VersionPrefix>
<VersionPrefix>2.3.0</VersionPrefix>
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Bump major version for public interface change

This release is tagged as 2.3.0, but the same commit adds MfaSecondFactor to the public ICognitoUserPoolConstructProps interface, which is a source-breaking API change for any downstream code that implements that interface. Consumers that auto-accept minor updates can hit compile failures after upgrading, so this should be shipped as a major version bump (or the interface change avoided) to preserve semantic-version expectations.

Useful? React with 👍 / 👎.

<!-- SPDX license identifier for MIT -->
<PackageLicenseExpression>MIT</PackageLicenseExpression>

Expand Down
1 change: 1 addition & 0 deletions src/LayeredCraft.Cdk.Constructs/CognitoUserPoolConstruct.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ public CognitoUserPoolConstruct(
},
AccountRecovery = AccountRecovery.EMAIL_ONLY,
Mfa = props.Mfa,
MfaSecondFactor = props.MfaSecondFactor,
RemovalPolicy = props.RemovalPolicy,
});

Expand Down
4 changes: 4 additions & 0 deletions src/LayeredCraft.Cdk.Constructs/Models/CognitoUserPoolConstructProps.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ public interface ICognitoUserPoolConstructProps

Mfa Mfa { get; }

MfaSecondFactor? MfaSecondFactor { get; }

int PasswordMinLength { get; }

IReadOnlyList<ICognitoResourceServerProps> ResourceServers { get; }
Expand All @@ -31,6 +33,8 @@ public sealed record CognitoUserPoolConstructProps : ICognitoUserPoolConstructPr

public Mfa Mfa { get; init; } = Mfa.OFF;

public MfaSecondFactor? MfaSecondFactor { get; init; }

public int PasswordMinLength { get; init; } = 12;
public IReadOnlyList<ICognitoResourceServerProps> ResourceServers { get; init; } = [];
public IReadOnlyList<ICognitoUserPoolAppClientProps> AppClients { get; init; } = [];
Expand Down
Loading