Skip to content

Add confetti effect on game over#2

Open
dencee wants to merge 2 commits intomainfrom
TurkeyFeatures
Open

Add confetti effect on game over#2
dencee wants to merge 2 commits intomainfrom
TurkeyFeatures

Conversation

@dencee
Copy link
Collaborator

@dencee dencee commented Nov 18, 2020

*Add confetti effect on game over
*Add constructor to Turkey class to initialize with a different image

@dencee dencee requested a review from jaLeague November 18, 2020 23:27
@jaLeague
Copy link
Contributor

I would prefer that there be two constructor variants. The new one with the option of changing the image for each turkey, but keep the original that uses the default (provided) turkey image for all.

Also, new constructor needs to resize image after loading.

Love the confetti addition!!

@dencee
Copy link
Collaborator Author

dencee commented Nov 20, 2020

*Kept the original Turkey constructor
*Resized after loading turkey image
*Moved the background draw for the confetti to show up correctly.

Thanks for the review!

@jaLeague
Copy link
Contributor

Unfortunately, moving the background draw to another part of the code means that the user can no longer know who won the race. For this implementation, the instruction to write "winner" on the race lane should be removed since it is never seen. Maybe rework it so the "race over" screen can also display who won ?

dencee added a commit that referenced this pull request Dec 23, 2020
dencee added a commit that referenced this pull request Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants