Open
Conversation
bbnhfg
suggested changes
May 11, 2018
src/containers/index.js
Outdated
|
|
||
| import {createStore} from '../lib/store'; | ||
| import HomeScreen from './HomeScreen'; | ||
| // import HomeScreen from './HomeScreen'; |
Contributor
There was a problem hiding this comment.
так, комменченый код давайте сразу выпиливать
src/reducers/index.js
Outdated
| nav, | ||
| }); | ||
|
|
||
| export default AppReducer; |
Contributor
There was a problem hiding this comment.
редюсеры давайте хранить в отдельных файлах с папке reducers, то есть это перенести в reducers/navigation а в reducers/index только склеивать их через combineReducers
| const mapStateToProps = state => ({ | ||
| nav: state.nav, | ||
| }); | ||
|
|
Contributor
There was a problem hiding this comment.
то что лежит в компонентах никогда не конектится к стору
Collaborator
There was a problem hiding this comment.
| static propTypes = { | ||
| dispatch: PropTypes.func.isRequired, | ||
| nav: PropTypes.object.isRequired, // eslint-disable-line | ||
| }; |
Contributor
There was a problem hiding this comment.
не надо это правило дизейблить, не используем PropTypes.object, нужно прописывать через PropTypes.shape именно те поля которые используются в компоненте, если структура повторяется несколько раз, выносить в отдельный файл, например lib/prop-types.js
или constants/prop-types.js
Mafark
force-pushed
the
add-navigators
branch
3 times, most recently
from
80f9fbf to
768aa6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.