Skip to content

Comments

feat(ltk-overlay): binary game index#128

Merged
Crauzer merged 2 commits intomainfrom
game-index-optimization
Feb 18, 2026
Merged

feat(ltk-overlay): binary game index#128
Crauzer merged 2 commits intomainfrom
game-index-optimization

Conversation

@Crauzer
Copy link
Member

@Crauzer Crauzer commented Feb 18, 2026

No description provided.

@Crauzer Crauzer changed the title feat(ltk-overlay): integrate rmp-serde for MessagePack serialization feat(ltk-overlay): binary game index Feb 18, 2026
@Crauzer Crauzer requested a review from Copilot February 18, 2026 14:45
@Crauzer Crauzer moved this to In Progress in league-mod Feb 18, 2026
@Crauzer Crauzer self-assigned this Feb 18, 2026
@Crauzer Crauzer added overlay Issues related to WAD overlay builder (ltk_overlay) performance Performance optimization labels Feb 18, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request optimizes the game index caching system by switching from JSON to MessagePack serialization and changing content hash computation from eager pre-computation to lazy on-demand calculation.

Changes:

  • Replaced JSON serialization with MessagePack for the game index cache (file renamed from game_index_cache.json to game_index.bin)
  • Removed pre-computed content hashes from GameIndex structure to avoid hashing ~500k chunks during indexing
  • Added on-demand compute_content_hashes_batch() method that only computes hashes for chunks actually overridden by mods
  • Refactored index building to perform a single directory walk, reusing results across multiple builder functions

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
crates/ltk_overlay/src/game_index.rs Converted cache serialization to MessagePack, removed content_hashes field, added on-demand batch content hash computation, refactored to reuse directory walk results
crates/ltk_overlay/src/builder.rs Updated filter_overrides to use new on-demand content hash computation, updated documentation references from .json to .bin
crates/ltk_overlay/Cargo.toml Added rmp-serde dependency for MessagePack serialization
Cargo.lock Reflected rmp-serde dependency addition

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Crauzer Crauzer merged commit b84fe98 into main Feb 18, 2026
15 checks passed
@Crauzer Crauzer deleted the game-index-optimization branch February 18, 2026 15:05
@github-project-automation github-project-automation bot moved this from In Progress to Done in league-mod Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

overlay Issues related to WAD overlay builder (ltk_overlay) performance Performance optimization

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant