Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request optimizes the game index caching system by switching from JSON to MessagePack serialization and changing content hash computation from eager pre-computation to lazy on-demand calculation.
Changes:
- Replaced JSON serialization with MessagePack for the game index cache (file renamed from
game_index_cache.jsontogame_index.bin) - Removed pre-computed content hashes from GameIndex structure to avoid hashing ~500k chunks during indexing
- Added on-demand
compute_content_hashes_batch()method that only computes hashes for chunks actually overridden by mods - Refactored index building to perform a single directory walk, reusing results across multiple builder functions
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/ltk_overlay/src/game_index.rs | Converted cache serialization to MessagePack, removed content_hashes field, added on-demand batch content hash computation, refactored to reuse directory walk results |
| crates/ltk_overlay/src/builder.rs | Updated filter_overrides to use new on-demand content hash computation, updated documentation references from .json to .bin |
| crates/ltk_overlay/Cargo.toml | Added rmp-serde dependency for MessagePack serialization |
| Cargo.lock | Reflected rmp-serde dependency addition |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.