Skip to content

Comments

feat(ltk_mapgeo): bucketed geometry builder#107

Merged
Crauzer merged 2 commits intomainfrom
bucketed-geo-builder
Feb 23, 2026
Merged

feat(ltk_mapgeo): bucketed geometry builder#107
Crauzer merged 2 commits intomainfrom
bucketed-geo-builder

Conversation

@Crauzer
Copy link
Member

@Crauzer Crauzer commented Feb 23, 2026

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a public builder API for ltk_mapgeo bucketed scene-graph geometry and a comprehensive integration test suite to validate bucketing, packing, and visibility-flag behavior.

Changes:

  • Introduces BucketedGeometry::build(...) with BucketGridConfig and BuildError to build bucketed geometry from world-space triangles.
  • Exposes the new build API types via scene_graph and crate-level re-exports.
  • Adds integration tests covering validation, bucketing behavior, packing/layout, determinism, and visibility flag reordering.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
crates/ltk_mapgeo/tests/build_bucketed_geometry.rs New integration tests for bucket assignment, packing, validation errors, determinism, and flags handling.
crates/ltk_mapgeo/src/scene_graph/mod.rs Wires in the new build module and re-exports BucketGridConfig/BuildError.
crates/ltk_mapgeo/src/scene_graph/build.rs Implements BucketedGeometry::build and defines BucketGridConfig + BuildError.
crates/ltk_mapgeo/src/lib.rs Re-exports BucketGridConfig and BuildError at crate root.
CLAUDE.md Adds repository working guidelines and common commands.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Crauzer Crauzer self-assigned this Feb 23, 2026
@Crauzer Crauzer added the area:api Public API design label Feb 23, 2026
@Crauzer Crauzer moved this to In Progress in league-toolkit Feb 23, 2026
@Crauzer Crauzer merged commit da0826e into main Feb 23, 2026
1 check passed
@Crauzer Crauzer deleted the bucketed-geo-builder branch February 23, 2026 11:57
@github-project-automation github-project-automation bot moved this from In Progress to Done in league-toolkit Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:api Public API design

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant