feat(ltk_mapgeo): bucketed geometry builder#107
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a public builder API for ltk_mapgeo bucketed scene-graph geometry and a comprehensive integration test suite to validate bucketing, packing, and visibility-flag behavior.
Changes:
- Introduces
BucketedGeometry::build(...)withBucketGridConfigandBuildErrorto build bucketed geometry from world-space triangles. - Exposes the new build API types via
scene_graphand crate-level re-exports. - Adds integration tests covering validation, bucketing behavior, packing/layout, determinism, and visibility flag reordering.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| crates/ltk_mapgeo/tests/build_bucketed_geometry.rs | New integration tests for bucket assignment, packing, validation errors, determinism, and flags handling. |
| crates/ltk_mapgeo/src/scene_graph/mod.rs | Wires in the new build module and re-exports BucketGridConfig/BuildError. |
| crates/ltk_mapgeo/src/scene_graph/build.rs | Implements BucketedGeometry::build and defines BucketGridConfig + BuildError. |
| crates/ltk_mapgeo/src/lib.rs | Re-exports BucketGridConfig and BuildError at crate root. |
| CLAUDE.md | Adds repository working guidelines and common commands. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.