Conversation
There was a problem hiding this comment.
Pull request overview
Adds incremental extraction support to wadtools extract by skipping already-extracted outputs by default, with an opt-in flag to overwrite.
Changes:
- Added
--overwriteflag to theextractsubcommand and plumbed it through the CLI argument layer. - Updated the extractor to skip writing when the destination file already exists (unless overwriting), and to report skipped-existing counts.
- Updated README usage/docs to describe the new behavior and flag.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| crates/wadtools/src/main.rs | Adds the --overwrite CLI flag and passes it into extraction args. |
| crates/wadtools/src/extractor.rs | Implements skip-existing/overwrite behavior during chunk writes and returns extracted + skipped counts. |
| crates/wadtools/src/commands/extract.rs | Adapts to the new extractor return type and logs skipped-existing counts. |
| README.md | Documents --overwrite and provides examples for re-extraction behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
9412e06 to
e92e0ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.