Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds extraction summary statistics to wadtools extract, including counts, total bytes written, and a per-file-type breakdown.
Changes:
- Introduces
ExtractStatsreturned fromExtractor::extract_chunks, tracking extracted/skipped counts, total bytes written, and counts byLeagueFileKind. - Adds an
extractCLI flag to show stats and prints a formatted summary after extraction. - Moves
format_sizeintoutilsfor reuse and addsdashmapas a dependency to aggregate per-type counts concurrently.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/wadtools/src/utils/mod.rs | Adds shared format_size() helper used by list/extract output. |
| crates/wadtools/src/main.rs | Adds --stats/-s option to the extract subcommand and wires it into ExtractArgs. |
| crates/wadtools/src/extractor.rs | Implements ExtractStats collection (bytes + per-type counts) during extraction. |
| crates/wadtools/src/commands/list.rs | Switches to shared utils::format_size (removes local copy). |
| crates/wadtools/src/commands/extract.rs | Prints extraction summary stats (including bytes and by-type breakdown). |
| crates/wadtools/Cargo.toml | Adds dashmap dependency. |
| Cargo.lock | Locks dashmap and transitive dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.