Skip to content

470 integer child ages#473

Open
paddy-r wants to merge 9 commits intodevelopmentfrom
470_integer_child_ages
Open

470 integer child ages#473
paddy-r wants to merge 9 commits intodevelopmentfrom
470_integer_child_ages

Conversation

@paddy-r
Copy link
Collaborator

@paddy-r paddy-r commented Dec 2, 2024

Do...

  • baseline, general check -> runs without errors
  • handovers, see that child ages and nkids (hh) look okay, maybe compare with development handovers, should be identical -> see images below, some differences -> not identical but very similar
  • Do spot checks on child ages -> marking as done because not necessary as child age plots very similar to development

@paddy-r paddy-r linked an issue Dec 2, 2024 that may be closed by this pull request
3 tasks
@paddy-r paddy-r self-assigned this Dec 2, 2024
@paddy-r
Copy link
Collaborator Author

paddy-r commented Dec 2, 2024

@RobertClay don't like the look of this but presumably not related to child ages:

image

@paddy-r
Copy link
Collaborator Author

paddy-r commented Dec 2, 2024

Also getting this, is it a leading zeroes issue?

image

@paddy-r
Copy link
Collaborator Author

paddy-r commented Dec 6, 2024

Child ages in handovers.

  1. 470_integer_child_ages, looks reasonable.

image

  1. development, looks very similar.

image

@paddy-r
Copy link
Collaborator Author

paddy-r commented Dec 6, 2024

@RobertClay all looks good, happy to merge if you are, although if you want a spot check of some child ages, I'd need to delve into the code a bit more.

@paddy-r
Copy link
Collaborator Author

paddy-r commented Jan 23, 2025

@RobertClay don't merge this yet, got a few changes to make...

@paddy-r
Copy link
Collaborator Author

paddy-r commented Jan 24, 2025

All looking good following some harmonisation with other improvements on 369-refactor.

image

@paddy-r paddy-r assigned paddy-r and unassigned paddy-r Jan 31, 2025
@paddy-r
Copy link
Collaborator Author

paddy-r commented Jan 31, 2025

@RobertClay Potential issue: can you check Ageing.update_binary_child_ages. I think it needs a groupby on hidp to correctly update nkids and child_ages. Currently updating at individual level, not hh level.

@RobertClay
Copy link
Collaborator

RobertClay commented Jan 31, 2025

Hi,

Should be as simple as

  • use groupby to take the first household under each hidp.
  • apply child age update.
  • transform back onto main vivarium population frame. use the new age chain and hidps as a dictionary.

maybe need to do same with fertility here as well. doing only once per house but make sure to account for multiple births twins two mothers etc.

not sure if you're asking me to do it or how to do it. happy to discuss more.

@RobertClay
Copy link
Collaborator

now I think about it theres a few things this could be done for. housing neighbourhood etc. reducing number of computations. it gets tricky though as multiple family members may be predicted different states.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

moving from string child ages to binary

2 participants