[4주차] 이은표/[feat] 추가 api 구현#156
Open
vyfhfhd wants to merge 7 commits intoLeets-Official:이은표/mainfrom
Hidden character warning
The head ref may contain hidden characters: "\uc774\uc740\ud45c/4\uc8fc\ucc28"
Open
Conversation
KunHeeLee7
reviewed
Apr 30, 2026
KunHeeLee7
left a comment
KunHeeLee7
left a comment
There was a problem hiding this comment.
과제 하시느라 수고 많으셨습니다! 저는 구현하지 못했던 댓글 기능을 구현해주셔서, 나중에 해당 기능을 구현하는 데 큰 도움이 될 것 같습니다. 감사합니다 😊
| CommentResponse.CreateCommentResponse response = | ||
| commentService.createComment(postId, userId, request); | ||
|
|
||
| return ApiResponse.success("COMMENT_CREATED", "댓글 작성 성공", response); |
There was a problem hiding this comment.
🛠️ 성공 응답 코드와 실패 응답 코드의 네이밍 규칙이 다소 다른 것 같습니다. 응답 코드를 일관된 규칙으로 구성하면 API 응답을 이해하기 더 쉬울 것 같습니다 👍
There was a problem hiding this comment.
해당 파일은 신고 관련 Request DTO이기 때문에 report 디렉토리에 두는 것이 더 자연스러울 것 같아 조심스럽게 의견 드립니다 😊
kangyeson
reviewed
Apr 30, 2026
kangyeson
left a comment
kangyeson
left a comment
There was a problem hiding this comment.
Comment Entity를 여러 상태로 분기하여 구현하신 점이 인상 깊었습니다. 코드도 깔끔하게 정리해주셔서 보기 편했습니다ㅎㅎ 고생하셨습니다~!
Nanajun22
reviewed
Apr 30, 2026
| } | ||
|
|
||
| report.resolve(); | ||
|
|
There was a problem hiding this comment.
댓글 신고 승인 로직에서 신고 엔티티의 상태만 수정하도록 구현하셨는데 일반적인 댓글 도메인에서는 신고 기능을 구현할 때 비즈니스 요구사항에 맞춰 도메인 처리도 같이 구현하기 때문에 요구사항을 가정해서 구현해보면 좋을 것 같습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. 과제 요구사항 중 구현한 내용
2. 핵심 변경 사항
posts/{postId}/comments/comments?userId=iposts/{postId}/comments/{commentId}/likesposts/{postId}/comments/{commentId}/reportsposts/{postId}/comments/{commentId}/reports/{reportId}/resolve3. 실행 및 검증 결과
댓글 작성
댓글 좋아요
댓글 좋아요 중복 방지
댓글 신고 사유x
댓글 신고 정상처리
댓글 신고 중복 방지
댓글 신고 상태 처리 완료
4. 완료 사항
5. 추가 사항
closed #132제출 체크리스트
{이름}/main브랜치다{이름}/{숫자}주차브랜치다Reviewer 참고