[2주차] 이설아/[feat] 상세 기능 구현#6
Open
seola12e wants to merge 2 commits intoLeets-Official:mainfrom
Hidden character warning
The head ref may contain hidden characters: "\uc774\uc124\uc544/2\uc8fc\ucc28"
Open
Conversation
rootTiket
approved these changes
Mar 31, 2025
Member
rootTiket
left a comment
rootTiket
left a comment
There was a problem hiding this comment.
크게 문제있어보이는 부분은 없네요!! 고생하셨습니다
코멘트 읽어보시면 좋을것 같아요!!
Comment on lines
+4
to
+5
| username: root | ||
| password: root |
Member
There was a problem hiding this comment.
현재는 미션 환경이라 노출되어도 괜찮으나, 추후에는 환경변수로 관리하는 것을 추천드립니다!!
Comment on lines
+138
to
+143
| """, (rs, rowNum) -> new Employee( | ||
| rs.getLong("id"), | ||
| rs.getString("name"), | ||
| rs.getLong("department_id"), | ||
| rs.getInt("salary"), | ||
| rs.getLong("manager_id") |
Member
There was a problem hiding this comment.
매번 매핑하는 방식도 괜찮지만 (지금의 경우, 중복이 적기 때문) 매핑하는 메서드를 따로 만드는 것도 고려해보시면 좋을것 같습니다! RowMapper를 이용하시면 구현할 수 있습니다~!
참고자료 : https://mincanit.tistory.com/13
soyesenna
approved these changes
Apr 2, 2025
soyesenna
left a comment
soyesenna
left a comment
There was a problem hiding this comment.
구현 고생하셨어요!
jdbcTemplate의 여러 메서드들을 적절하게 활용하신 것 같네요👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
테스트 결과
추가사항
closed #5