[2주차] 최형록/[feat] 상세 기능 구현#7
Open
RokChoi wants to merge 1 commit intoLeets-Official:mainfrom
Hidden character warning
The head ref may contain hidden characters: "\ucd5c\ud615\ub85d/2\uc8fc\ucc28"
Open
Conversation
rootTiket
reviewed
Apr 1, 2025
Comment on lines
+4
to
+5
| username: root | ||
| password: root |
Member
There was a problem hiding this comment.
현재는 과제 진행중이라 괜찮지만 추후에는 환경변수로 대체하는 것이 이상적입니다! :)
rootTiket
reviewed
Apr 1, 2025
Comment on lines
+163
to
+169
| return jdbcTemplate.query(sql, (rs, rowNum) -> new Employee( | ||
| rs.getLong("id"), | ||
| rs.getString("name"), | ||
| rs.getLong("department_id"), | ||
| rs.getInt("salary"), | ||
| rs.getObject("manager_id") != null ? rs.getLong("manager_id") : null | ||
| )); |
Member
There was a problem hiding this comment.
RowMapper를 이용할 수도 있어요! 중복되는 Employee 매핑 코드를 줄일 수 있을것 같네요 :):)
rootTiket
reviewed
Apr 1, 2025
Member
rootTiket
left a comment
rootTiket
left a comment
There was a problem hiding this comment.
고생하셨습니다~! 이번에 노트북 로컬에 mysql을 설치하셨다면 다음에는 docker를 이용해보시는 것도 권장 드려요 !!
soyesenna
reviewed
Apr 2, 2025
soyesenna
left a comment
soyesenna
left a comment
There was a problem hiding this comment.
고생하셨어요!
SQL을 문자열로 정의하고 query 메서드로 실행하셨군요!
jdbcTemplate에는 query 말고도 여러 메서드가 있습니다!
해당 메서드들을 조금 더 공부해보시면 좋을 것 같아요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
테스트 결과
추가 사항
closed #4